Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ICS04] Sync channel events with the naming convention #750

Closed
Farhad-Shabani opened this issue Jul 7, 2023 · 0 comments · Fixed by #751
Closed

[ICS04] Sync channel events with the naming convention #750

Farhad-Shabani opened this issue Jul 7, 2023 · 0 comments · Fixed by #751
Assignees
@Farhad-Shabani
Labels
O: code-hygiene Objective: aims to improve code hygiene
Milestone
v0.43.1

Comments

@Farhad-Shabani
Copy link
Member

Summary

Fields and methods of the event types under ics04 do not comply with our naming convention stated here.
@Farhad-Shabani Farhad-Shabani added the O: code-hygiene Objective: aims to improve code hygiene label Jul 7, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jul 7, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Jul 7, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jul 7, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Jul 10, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.42.0 milestone Jul 17, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.42.0, v0.43.1 Jul 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
O: code-hygiene Objective: aims to improve code hygiene
Projects
None yet
Milestone
v0.43.1
Development

Successfully merging a pull request may close this issue.

imp(ics04)!: sync naming for channel events with the convention informalsystems/ibc-rs
1 participant
@Farhad-Shabani