Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

imp(ics04)!: sync naming for channel events with the convention #751

Merged
merged 1 commit into from
Jul 7, 2023
Merged

imp(ics04)!: sync naming for channel events with the convention #751

merged 1 commit into from
Jul 7, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #750

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review July 7, 2023 19:09
@Farhad-Shabani Farhad-Shabani merged commit 98594ae into main Jul 7, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/sync-ics04-events-namings branch July 7, 2023 19:10
@Farhad-Shabani Farhad-Shabani self-assigned this Jul 10, 2023
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
imp(ics04): sync naming for channel events with the convention (#751)
d3ec8ec
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees

@Farhad-Shabani Farhad-Shabani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICS04] Sync channel events with the naming convention
2 participants
@Farhad-Shabani @plafer