feat: Add ProtoJSON-compatible Serialize and Deserialize instances on all Protobuf definitions via pbjson
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
Serialize and Deserialize on all Protobuf definitions via pbjsonSerialize and Deserialize on all Protobuf definitions via pbjson
romac
changed the title
Serialize and Deserialize on all Protobuf definitions via pbjsonSerialize and Deserialize instances on all Protobuf definitions via pbjson
romac
changed the title
Serialize and Deserialize instances on all Protobuf definitions via pbjsonSerialize and Deserialize instances on all Protobuf definitions via pbjson
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
===========================================
+ Coverage 50.54% 65.27% +14.72%
===========================================
Files 23 8 -15
Lines 8034 3551 -4483
Branches 86 0 -86
===========================================
- Hits 4061 2318 -1743
+ Misses 3616 1233 -2383
+ Partials 357 0 -357
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This was referenced Apr 22, 2023
Merged
hdevalence
approved these changes
Apr 25, 2023
tac0turtle
approved these changes
Apr 26, 2023
romac
pushed a commit
that referenced
this pull request
Aug 16, 2023
Closes: #156 Addresses the `no_std` compatibility issue with `serde` feature in `ibc-rs`. This is caused by the recent implementation of ProtoJSON serialization and deserialization [0] for the `ics23` Protobuf definitions using `pbjson`, and then re-exporting the ics23 type [1] in `ibc-proto-rs`. Some of our users by then (starting from IBC-rs v0.41.0) are experiencing compilation errors. [2] To meet this immediate need [3] and the lack of activity in the `pbjson` crate for months, we have taken the initiative to feature `no_std` support in the `informalsystems-pbjson` crate and have it published. [0] #146 [1] cosmos/ibc-proto-rs#92 [2] informalsystems/ibc-rs#741 [3] cosmos/ibc-proto-rs#98 (comment) --- * feat: enable no_std support for pbjson * fix: get serde feature work with no-std * deps: use informalsystems-pbjson v0.6.0 * deps: use informalsystems-pbjson v0.6.0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #144
Supersedes: #145