Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(rust): Update informalsystems-pbjson to v0.7.0 #274

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jan 25, 2024

No description provided.

@romac romac requested a review from Farhad-Shabani January 25, 2024 15:55
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (d1f9873) 49.30% compared to head (829d232) 65.90%.

Files Patch % Lines
rust/src/cosmos.ics23.v1.serde.rs 45.34% 47 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #274       +/-   ##
===========================================
+ Coverage   49.30%   65.90%   +16.60%     
===========================================
  Files          23        7       -16     
  Lines       10089     3640     -6449     
  Branches       86        0       -86     
===========================================
- Hits         4974     2399     -2575     
+ Misses       4750     1241     -3509     
+ Partials      365        0      -365     
Flag Coverage Δ
go ?
rust 65.90% <45.34%> (+0.07%) ⬆️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac changed the title Update informalsystems-pbjson to v0.7.0 chore(rust): Update informalsystems-pbjson to v0.7.0 Jan 25, 2024
@romac romac marked this pull request as draft January 25, 2024 16:22
@romac romac marked this pull request as ready for review January 25, 2024 17:03
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@romac romac merged commit 4e43a84 into master Jan 25, 2024
6 of 7 checks passed
@romac romac deleted the romac/rust/update-pbjson branch January 25, 2024 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants