Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Osmosis assets_2.json (Round 3 of Validating Generated Output) #2020

Merged

Conversation

JeremyParish69
Copy link
Contributor

@JeremyParish69 JeremyParish69 commented Nov 13, 2024

After having added chain_name overrides.
This is a direct copy-and-paste from output, and the little difference proves that the generated assets file from Osmosis Labs is compatible with Cosmostation's required format.

There was recently a bulk cleanup at the Chain Registry of Coingecko IDs that no longer exist. That's why many CoinGecko IDs are being removed.

DGN is new, so is being added.

SHIDO is being added back in. Why was it removed?

@JeremyParish69 JeremyParish69 marked this pull request as ready for review November 13, 2024 20:27
@wannabit-yongjoo
Copy link
Member

Shido has 2 coin in osmois.

ibc/BBE825F7D1673E1EBF05AB02000E23E6077967B79547A3733B60AE4ED62C4D32 looks not working.

even osmosis dex only using
ibc/62B50BB1DAEAD2A92D6C6ACAC118F4ED8CBE54265DCF5688E8D0A0A978AA46E7

https://github.com/cosmos/chain-registry/blob/master/osmosis/assetlist.json#L25456
https://github.com/cosmos/chain-registry/blob/master/osmosis/assetlist.json#L17856

@JeremyParish69 JeremyParish69 marked this pull request as draft November 14, 2024 16:43
@JeremyParish69
Copy link
Contributor Author

Updated again, so the duplicate SHIDO has been removed (and KIMA was updated)

@JeremyParish69 JeremyParish69 marked this pull request as ready for review November 14, 2024 18:02
@wannabit-yongjoo wannabit-yongjoo merged commit afd1381 into cosmostation:main Nov 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants