Refactor AT services #461
Merged
Refactor AT services #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
share all data using only AcraTranslatorData struct * pass build flags in integrations tests * fix overriding test in integrations tests * make getClientID as separate function instead of method of TLSServiceWrapper
ZhmakAS
reviewed
Nov 24, 2021
| // OngRPCServerInit call all registered callbacks on gRPC server initialization | ||
| func OngRPCServerInit(server *grpc.Server, data *common.TranslatorData, service DecryptService) { | ||
| lock.Lock() | ||
| defer lock.Unlock() |
There was a problem hiding this comment.
Do we really need to use defer here? If I am not mistaken the OnServerInit function does not return any error so here no possible early-exit scenarios, right? Could we place it after the loop statement?
There was a problem hiding this comment.
Defer has used because of subscribers may panic. Yes, the program will interrupt and exit if nothing catches this panic. But for a future better to handle it from the start correctly.
…ide of newServer function
update golang services according to updates grpc/grpc-go#3669 update Makefile with up-to-date building commands
ZhmakAS
approved these changes
Nov 25, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are nothing changed in features or public API. Only internal structures and implementations.
All shared components have moved to
AcraTranslatorDatastructure that used to initialize services (HTTP, gRPC) and passed to callbacks that called on server initialization.Refactored initialization dependencies like poison record callbacks, tokenizer and moved them from redundant factories to program startup to initialize them at start and share.
Added registries that store callbacks for events from gRPC/HTTP servers. It helps extend implementation with build flags. Also, updates integration tests with new env variable that accept and pass build flags for compilation commands.
Updated
go_packageoption in .proto file to full path to fix import in other .proto filesAnd renamed
TestPoisonRecordWholeCellStatusOff(that exists in 2 examples) with proper suffix.Checklist
with new changes