Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

android-build: Update base image and Android build tools #6

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

ilammy
Copy link
Contributor

@ilammy ilammy commented Aug 31, 2022

ilammy added 5 commits August 31, 2022 20:15
* Install Java 11 side-by-side with Java 8

Because Android SDK manager needs Java 8 while the rest of Gradle
toolchain needs Java 11. Don't think about it, just download.

Note that Java 11 has JDK -- with compiler and stuff, we'll need that
for building Android things like javadoc.

* Install shasum to check integrity

Because if you're downloading random crap from the internet then at
least check that it's expected crap.
New tools, new name, new retarded location requirements. Because
of course they had to change, why else?
Also, kick off Android emulator and base image. This Docker image
is used mostly for building Android stuff, not running emulator.
For actually running Android software you're better off installing
Android Studio.
@Lagovas
Copy link

Lagovas commented Aug 31, 2022

can you remind where we use this image? as I understand, for themis we use github ci with their own images.

@ilammy
Copy link
Contributor Author

ilammy commented Aug 31, 2022

can you remind where we use this image?

Supposedly, whoever publishes AndroidThemis releases should be using this image for building them. I'm not aware how well automation penetrated and whether this image is actually used, or there's something else in BuildBot.

This image is also the one used in documentation on how to build AndroidThemis from source.

It is not used by GitHub CI. Those builds use the base system directly, using preinstalled SDK, NDK, etc.

@Lagovas
Copy link

Lagovas commented Aug 31, 2022

did you try to build using updated image and instructions from docs? to be sure that it will not be broken after update. or we need to update docs?

@ilammy
Copy link
Contributor Author

ilammy commented Aug 31, 2022

did you try to build using updated image and instructions from docs?

Sure. It worked for me.

or we need to update docs?

The only change after AndroidThemis 0.15 release would be

 The resulting Android library (AAR) will be placed into
-`src/wrappers/themis/android/build/outputs/aar/android.aar`.
+`src/wrappers/themis/android/build/outputs/aar/android-release.aar`.
 You can then rename it and add to your project.

@vixentael
Copy link
Contributor

The only change after AndroidThemis 0.15 release would be

we plan to release 0.15? Hm :)
I thought it gonna be 0.14.XX

@vixentael
Copy link
Contributor

Taking about the docs, pls take a look at this draft PR.
https://github.com/cossacklabs/product-docs/pull/265/files

Are these changes enough?

@ilammy
Copy link
Contributor Author

ilammy commented Sep 1, 2022

we plan to release 0.15? Hm :)
I thought it gonna be 0.14.XX

However you want to manage that release. If a hotfix for Android would become necessary, I believe hope the old code would still build in the old Docker image. This doesn't sound like a hard thing to backport to release/0.14 branch though.

Taking about the docs, pls take a look at this draft PR.

Are these changes enough?

Yes. Thank you for updating the version as well!

@vixentael vixentael merged commit 9bb84f9 into cossacklabs:master Sep 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants