test that length of encrypted data == length of raw data #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
approved these changes
Jan 17, 2018
|
New test checks are always welcomed! Cool that we will check message length now |
vixentael
added
W-PHPThemis 🐘
|
Google tells me that it should be |
vixentael
reviewed
Jan 17, 2018
tests/phpthemis/scell_test.php
Outdated
| @@ -100,6 +100,7 @@ public function testTokenProtectWithContext($key, $message, $context, $iscorrect | |||
| $this->setExpectedException('Exception'); | |||
| } | |||
| $encrypted_message = phpthemis_scell_token_protect_encrypt($key, $message, $context); | |||
| $this->assertEquals(strlen($encrypted_message), strlen($message)); | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested python/C tests, but didn't check locally php version update. but ci should test it