hotfix: themis macos SPM, fix symlinks as required by Apple guide #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radetsky
requested review from
vixentael,
julepka,
ilammy and
shadinua
as code owners
|
Also this PR fixes #941 |
vixentael
approved these changes
Sep 7, 2022
|
we have tested, everything works, preparing for release |
vixentael
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have investigated the issues and found that themis.framework.zip which is located in "releases/0.13.12/download" section is incorrect for macOS. Part of the structure for macOS platforms contains regular files, not symlinks. The zip command needs the additional option "-y" to store symlinks.
I made a new themis.framework.zip and am ready to upload to GitHub immediately after release/hotfix 0.14.10