Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix references to comment parameter site.comments.provider #1629

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

Mascari4615
Copy link
Contributor

@Mascari4615 Mascari4615 commented Mar 24, 2024

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

I can't see the comments, because

In #1563, the parameter name of the comment has been changed from active to provider, but the change was not applied to comments switcher.

Additional context

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@cotes2020 cotes2020 changed the title fix: comments switcher Fix references to comment parameter site.comments.provider Mar 24, 2024
@cotes2020 cotes2020 merged commit 9508391 into cotes2020:master Mar 24, 2024
5 checks passed
@Mascari4615 Mascari4615 deleted the fix-comment branch March 24, 2024 17:02
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included or resolved in the release label May 11, 2024
kimbob13 pushed a commit to kimbob13/kimbob13.github.io that referenced this pull request May 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
released Included or resolved in the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants