Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add note about persistent connections #199

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

avsej
Copy link
Member

@avsej avsej commented Dec 5, 2024

This patch is related to DOC-12803. It documents INI options related to persistent connections.

More info about the concept is here: https://www.php.net/manual/en/features.persistent-connections.php

Copy link
Contributor

@raycardillo raycardillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly grammar / readability corrections, but I tried to add a few small things for extra clarity as well.

MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
Copy link

@ingenthr ingenthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It's going to be a great doc improvement, but has a few issues at the moment.

MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
avsej and others added 3 commits December 5, 2024 18:58
Co-authored-by: Ray Cardillo <1744144+raycardillo@users.noreply.github.com>
@avsej avsej requested review from raycardillo and ingenthr December 9, 2024 16:30
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
MIGRATION_FROM_3_x.md Outdated Show resolved Hide resolved
avsej and others added 2 commits December 9, 2024 17:31
Co-authored-by: Mateusz <matt.wozakowski@gmail.com>
Co-authored-by: Mateusz <matt.wozakowski@gmail.com>
@avsej avsej requested a review from Matt-Woz December 9, 2024 17:31
@avsej avsej dismissed stale reviews from ingenthr and raycardillo December 9, 2024 17:40

The concern with SDKv4 crashing with zero settings has been fixed in PR #200

@avsej avsej merged commit 8882b29 into couchbase:main Dec 9, 2024
119 of 126 checks passed
@avsej avsej deleted the note-about-persistent-connections branch December 9, 2024 17:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants