CBG-4322 use unique output files #7352
Open
+109
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4322 use unique output files
Written on top of #7351 code
In the case that there is a file with the same contents in multiple places, this fixes the idea that this writes this to the same file.
e.g.
log_file_path
in config.json is /var/log/sync_gatewayThere is /var/log/sync_gateway/sg_info.log and /home/sync_gateway/logs/sg_info.log
The two will be concatenated together before this fix. There's another fix in #7351 which canonicalizes the paths with
path.Pathlib.resolve
before uploading.I've considered whether to add some
log
messages to say where the files are picked up from, so we'd know why we got a duplicate. log is only written to stderr, but we could write tee to a file like sgcollect_info-output.log so we'd have an idea why things might go wrong.New tests were written.