Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CBG-4186: Put ISGR into an errored stopped state when a reconnect times out #7361

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

CBG-4186: Put ISGR into an errored stopped state when a reconnect times out #7361

wants to merge 6 commits into from
+93 −9

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Feb 5, 2025 •
edited
Loading

CBG-4186

Put ISGR into an errored stopped state when a reconnect times out

  • Allows replicator to be started again after timing out with a failed reconnect loop
  • Ensures replicator can be restarted again from this state in new test

Integration Tests

@bbrks bbrks self-assigned this Feb 5, 2025
bbrks
bbrks commented Feb 5, 2025
View reviewed changes
Copy link
Member Author

@bbrks bbrks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have unintended consequences for manually stopping a reconnecting replicator (via TestActiveReplicatorReconnectSendActions). Will spend some more time on it.

torcolvin
torcolvin reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just asking some questions, feel free to drop.

db/active_replicator_common.go Outdated Show resolved Hide resolved
db/active_replicator_common.go Outdated Show resolved Hide resolved
@bbrks
Simplify reconnectLoop error handling for logging - rely on retry loo…
adcb911 
…p error message which is now wrapping context err
@bbrks bbrks assigned torcolvin and unassigned bbrks Feb 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

Assignees

@torcolvin torcolvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrks @torcolvin