Adding support for dropwizard 0.7.X configuration files #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private int socketTimeout = 5000; // in milliseconds | ||
|
|
||
| public ScheduledReporter build(MetricRegistry registry) { | ||
| HttpTransport transport = new HttpTransport.Builder() |
|
A couple nits and then LGTM. It would be nice if you could add UDP configuration before merging, but I would also be fine with you introducing it in a future PR. |
tianx2
force-pushed
the
coursera-master
branch
from
9b51e32 to
639743a
Compare
Added dropwizard-metrics-datadog module to support dropwizard configurations for dropwizard 0.7.x projects Included directions in README Fixed some formatting issues
tianx2
force-pushed
the
coursera-master
branch
from
639743a to
ac95f85
Compare
|
@nickdella I'll try adding the UDP configuration soon (over the next few days). It shouldn't be that hard since you have nice Builder patterns for the transports. I would rather get that support in before you merge and do another release. |
|
Ok, lgtm! |
nickdella
added a commit
that referenced
this pull request
Oct 17, 2014
Adding support for dropwizard 0.7.X configuration files
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at adding dropwizard 0.7.X configuration file support which was the reason behind my original intention to upgrade
metrics-coreto 3.0.2. Let me know what you think.It currently only supports
HttpTransport. I'm trying to figure out a way to have add a transport key in the yaml configuration file where you can choose between http or udp.For more on dropwizard configuration files for reporters, see here.