Beta deployment #13
Merged
Beta deployment #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the project to es2015 module (coveo#2)
jeremierobert-coveo
force-pushed
the
beta-deployment
branch
from
ac3c408 to
6a45f29
Compare
tedre191
reviewed
Jul 25, 2019
tedre191
approved these changes
Jul 25, 2019
|
It's more simple as our use case is. |
|
While working on tagging etc, I'm not convinced by the fact that we seems to manually tag versions to trigger a new release, I think that we should have a beta tag, yes, but this tag should merely point at the tip of the master branch (i.e. latest PR merged) . Same for the latest tag in fact, it could point the tip of a'production' branch. We would update the production branch through a PR and could define the version bump through some tools like semantic-release (i.e. if we only have bug fix, bump the patch, if we have a feature, bump the minor, if we have a breaking change, bump the major. semver in short) I do agree tho that's currently Out-of-Scope, but that could be nice imo. |
mikegron
approved these changes
Jul 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a conditionnal deploy when the tag has beta in it.