ci(SFINT-2577): Ensure Prettier run properly on UNIX. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
19acba5 failed as expected. |
louis-bompart
added
the
ci & tools
louis-bompart
requested review from
jeremierobert-coveo,
nathanlb and
Neilerino
louis-bompart
changed the title
Neilerino
reviewed
Sep 26, 2019
| @@ -1,10 +1,10 @@ | |||
| *.svg | |||
There was a problem hiding this comment.
this is probably a silly question but what is different here? The changes look the same to me
There was a problem hiding this comment.
No such thing has a silly question ;P
It's the end of line terminator that have changed: it was a CRLF, it's now a LF, as specified by the .prettierrc.js
Neilerino
approved these changes
Sep 26, 2019
jeremierobert-coveo
requested changes
Sep 30, 2019
| @@ -23,8 +23,8 @@ | |||
| "css": "node ./scripts/css.js", | |||
| "dev": "node ./scripts/dev.server.js", | |||
| "watchTest": "karma start ./config/karma.config.js", | |||
| "lint": "prettier --check **/*", | |||
| "lint-fix": "prettier --write **/* ", | |||
| "lint": "prettier --check \"./**/*\" --config \".prettierrc.js\" --ignore-path \".prettierignore\"", | |||
There was a problem hiding this comment.
Why not targetting the json instead ?
There was a problem hiding this comment.
Because I changed it to a .js to be consistent with the other config files
There was a problem hiding this comment.
So where is you change to enable linux ?
There was a problem hiding this comment.
It's the wrapping of the glob (so **/* to \"./**/*\")
jeremierobert-coveo
approved these changes
Oct 7, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob was not resolved the same way due to escaping on bash vs Powershell, this is now fixed.
Also now using the standard .prettierrc.js, because .json is not standard.
Bash were the ones with degradation, and thus the CI did not trip on linting ('cause he's on Ubuntu)