-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SFINT-2878 Added Cypress functional tests #60
Conversation
Can you split the PR in two?
So we can distinguish the setup and the tests in our review (and upcoming /blame :P ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed setup, LGTM!
Would split the tests in another PR to have small scoped PR and easily reversible PRs 🎉
imo, the setup is pointless with at least a single test to test the test setup. |
The thing is if your tests become an issue, we will have a single commit to revert without having to untangle what to keep, what to ditch. It keeps things contained. Like, your setup should not be hard-linked with a feature |
19a5585
to
663b541
Compare
663b541
to
a0fe2ef
Compare
46b79a0
to
163e78c
Compare
Done |
Why not using TypeScript tests? It could allow us to refer to some code from our src easily (Like the classnames) |
Here some typescript sprinkle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! (Borat voice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the modification pages/index.html → pages/attached_result.html
, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
243b492
to
0ffedcb
Compare
I added Cypress to run functional test in the repo.
Here some screenshot.
And here too