Skip to content

Add regex evaluation timeout #1630

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Add regex evaluation timeout #1630

merged 4 commits into from
Feb 26, 2024

Conversation

mokarchi
Copy link
Contributor

@MarcoRossignoli
Copy link
Collaborator

I don't think we need this anti-DoS timeout...the inputs are under the control of the user that's using coverlet and not from "unknown users" like in case of a web app.
But if we want to add if in case someone is using it under some other tool where users can add arbitrary input we should at least increase a bit, 1 sec looks too few to me, we could put 10.

@mokarchi
Copy link
Contributor Author

@MarcoRossignoli Changed to 10 seconds

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@MarcoRossignoli MarcoRossignoli merged commit 783c482 into coverlet-coverage:master Feb 26, 2024
Bertk pushed a commit to Bertk/coverlet that referenced this pull request Aug 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants