Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove console log #106

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: remove console log #106

merged 1 commit into from
Feb 25, 2025

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Feb 25, 2025

Just delete some annoying log that also might be breaking the JSON parser

image

Summary by CodeRabbit

  • Chores
    • Streamlined the handling of CORS requests by removing unnecessary debug output while preserving existing functionality.

@anxolin anxolin requested a review from a team February 25, 2025 19:15
Copy link

coderabbitai bot commented Feb 25, 2025

Walkthrough

The change removes a logging statement from the delegator function in the CORS configuration. The line console.log('delegator', origin); has been deleted. All other logic—including the condition that checks for a localhost pattern and sets the appropriate CORS options—remains unchanged. No modifications were made to exported or public entities.

Changes

File Change Summary
apps/api/src/app/plugins/cors.ts Removed the logging statement (console.log('delegator', origin);) from the delegator function.

Sequence Diagram(s):

Poem

I’m a rabbit on code trails, hopping light and free,
Logging prints vanished—quiet as a tree.
CORS flows intact, simple and so neat,
My whiskers twitch with every bug beat.
Cheers to clean code and a server that’s elite!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48a5255 and 3e63a9c.

📒 Files selected for processing (1)
  • apps/api/src/app/plugins/cors.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/api/src/app/plugins/cors.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: docker (apps/twap)
  • GitHub Check: docker (apps/api)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anxolin anxolin merged commit 172b183 into main Feb 25, 2025
7 checks passed
@anxolin anxolin deleted the remove-log branch February 25, 2025 19:17
@anxolin
Copy link
Contributor Author

anxolin commented Feb 25, 2025

@shoom3301 merged as its low-risk and I'm trying to fix the logs

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant