Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Simplify API path #65

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Simplify API path #65

merged 1 commit into from
Jul 22, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jul 22, 2024

This PR simplifies paths (while keeping the slippage endpoint backward compatible)

image

You can test with:

image 
# Old path
curl http://localhost:3010/chains/1/markets/0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2-0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2/slippageTolerance -v

# New path
curl http://localhost:3010/1/markets/0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2-0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2/slippageTolerance -v

@anxolin anxolin requested a review from alfetopito July 22, 2024 17:35
@anxolin anxolin merged commit 6ce0f8f into main Jul 22, 2024
6 checks passed
@anxolin anxolin deleted the remove-chains-from-url branch July 22, 2024 17:36
@anxolin
Copy link
Contributor Author

anxolin commented Jul 22, 2024

Addressing post-merge reviews :)

alfetopito
alfetopito reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alfetopito alfetopito alfetopito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anxolin @alfetopito