chore: hotfix v0.6.4 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
commented
Jul 25, 2024
Comment on lines
+58
to
+60
| for await (const chunk of payload as ReadableStream) { | ||
| contents += chunk.toString(); // Process each chunk of data | ||
| } |
There was a problem hiding this comment.
This is the fix: consume the payload stream once, so it can be reused in the response and stored in the cache.
Comment on lines
+21
to
+22
| // Remove it so we can cache it properly | ||
| request.headers['accept-encoding'] = undefined; |
There was a problem hiding this comment.
This is needed since I don't know how to handle decompressing and re-compressing the reply afterwards.
|
Tested it on bff staging https://app.pulumi.com/cowprotocol/bff/staging/updates/178 Caching is working too (the important part) https://bff.barn.cow.fi/proxies/coingecko/simple/token_price/ethereum?contract_addresses=0x6B175474E89094C44Da98b954EedeAC495271d0F&vs_currencies=usd Will merge it, please post merge review. |
anxolin
reviewed
Jul 26, 2024
anxolin
added a commit
that referenced
this pull request
Jul 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes based off of https://github.com/cowprotocol/bff/releases/tag/v0.6.3 which is the current prod version.
Pointing to the new branch
v0.6.It fixes the issue with cached responses.
The requests are being cached, but the cached part is the stream, not the the actual payload.
Since the stream is consumed in the first reply, the subsequent tries in the cached version return nothing:
Note: in order to properly consume and cache the payload, I had to disable the compression, similar to what I did in my first attempt at this 55387a7