Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add balanceDiff on simulate bundle endpoint #89

Conversation

yvesfracari
Copy link
Contributor

@yvesfracari yvesfracari commented Oct 18, 2024

To test:

  • Run the automatic tests locally.

  • Test the simulation bundle endpoint result. If you need some example to test use:

    • from: 0x8ad599c3a0ff1de082011efddc58f1908eb6e6d8
    • to: 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2
    • calldata: 0xa9059cbb000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc200000000000000000000000000000000000000000000000000000000000186a0
    • chainId: 1

    With that you should be able to see a positive amount of balance diff on the address 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2 and negative for the address 0x8ad599c3a0ff1de082011efddc58f1908eb6e6d8.

    If you can add this as two equal transactions on the bundle, and the results should double from the single transaction test.

@alfetopito alfetopito merged commit ab05a2b into cowprotocol:main Oct 22, 2024
2 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants