Log reference solver (i.e., Quasimodo) solution when generating a ref_solver-surplus-ebbo error #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
requested changes
Jul 19, 2023
fhenneke
reviewed
Jul 20, 2023
fhenneke
reviewed
Jul 20, 2023
| if trade_alt is None: | ||
| self.logger.warning( | ||
| f"No alternative trade for uid {uid} and " | ||
| ref_solver_response = self.solve_order_with_reference_solver( |
There was a problem hiding this comment.
Potentially rename this to solution_alt? But this might be confusing in the sense that the solution format is then different in solution and solution_alt. Otherwise we could also change the variable name in get_trade_alternative, which is currently solution.
There was a problem hiding this comment.
I would probably say now that the get_trade_alternative name for the function might be not very good after all. The function is oblivious to whether this is an alternative execution or not, and the only thing it does is parse a given execution and returns a trade.
fhenneke
reviewed
Jul 20, 2023
- wrong function argument - solver response is not modified anymore when extracting execution info
fhenneke
approved these changes
Jul 20, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging of the solution generated by the reference solver, whenever this (in isolation) gives more surplus to an order that is executed by some solver in the competition.