Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Switch to "main" as default git branch #6

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Switch to "main" as default git branch #6

merged 1 commit into from
Aug 11, 2023

Conversation

freeekanayaka
Copy link
Member

No description provided.

@freeekanayaka
Switch to "main" as default git branch
bed7d7a 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (8aa2a0f) 76.46% compared to head (bed7d7a) 76.45%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   76.46%   76.45%   -0.02%     
==========================================
  Files          51       51              
  Lines        9685     9685              
  Branches     2451     2451              
==========================================
- Hits         7406     7405       -1     
- Misses       1092     1093       +1     
  Partials     1187     1187

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freeekanayaka freeekanayaka merged commit 3d5d8c3 into cowsql:main Aug 11, 2023
@freeekanayaka freeekanayaka deleted the master-to-main branch August 11, 2023 08:15
freeekanayaka added a commit to freeekanayaka/raft that referenced this pull request Sep 14, 2023
@freeekanayaka
uv/append: Don't call uvMaybeFireCloseCb() in uvAliveSegmentWriterClo…
250dd08 
…seCb

We actually don't track that there are pending segment writer close operations,
so this call to uvMaybeFireCloseCb() can't really unblock anything waiting on
it.

On the contrary, if it fires after the close callback has actually been fired,
it causes a double free:

=================================================================
==199067==ERROR: AddressSanitizer: attempting double-free on 0x602000000010 in thread T0:
    #0 0x7fd5e44d7288 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52
    cowsql#1 0x7fd5e4b5a259 in ioCloseCb src/raft.c:115
    cowsql#2 0x7fd5e4b84861 in uvMaybeFireCloseCbReal src/uv.c:202
    cowsql#3 0x7fd5e4afba70 in uv_run (/lib/x86_64-linux-gnu/libuv.so.1+0xfa70) (BuildId: 7f7f8c148150666c7b116bf98bf6e27f96c697a9)
    cowsql#4 0x55b25438ebe5 in SubmitRun tools/benchmark/submit.c:314
    cowsql#5 0x55b254388955 in main tools/benchmark/main.c:60
    cowsql#6 0x7fd5e42456c9  (/lib/x86_64-linux-gnu/libc.so.6+0x276c9) (BuildId: 072feb34c63e054d60d94cbc68d92e4caad25d72)
    cowsql#7 0x7fd5e4245784 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x27784) (BuildId: 072feb34c63e054d60d94cbc68d92e4caad25d72)
    cowsql#8 0x55b254388bf0 in _start (/home/free/src/c/raft/tools/.libs/raft-benchmark+0x7bf0) (BuildId: 09105ce7d1a7fe71ca812de2af648a85fc490ebb)

0x602000000010 is located 0 bytes inside of 15-byte region [0x602000000010,0x60200000001f)
freed by thread T0 here:
    #0 0x7fd5e44d7288 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52
    cowsql#1 0x7fd5e4b5a259 in ioCloseCb src/raft.c:115
    cowsql#2 0x7fd5e4b84861 in uvMaybeFireCloseCbReal src/uv.c:202
    cowsql#3 0x7fd5e4afba70 in uv_run (/lib/x86_64-linux-gnu/libuv.so.1+0xfa70) (BuildId: 7f7f8c148150666c7b116bf98bf6e27f96c697a9)

previously allocated by thread T0 here:
    #0 0x7fd5e44d85bf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    cowsql#1 0x7fd5e4b59983 in raft_init src/raft.c:62
    cowsql#2 0x55b25438e7d4 in serverInit tools/benchmark/submit.c:127
    cowsql#3 0x55b25438ebbf in SubmitRun tools/benchmark/submit.c:302
    cowsql#4 0x55b254388955 in main tools/benchmark/main.c:60
    cowsql#5 0x7fd5e42456c9  (/lib/x86_64-linux-gnu/libc.so.6+0x276c9) (BuildId: 072feb34c63e054d60d94cbc68d92e4caad25d72)

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka freeekanayaka mentioned this pull request Sep 14, 2023
Merged
freeekanayaka added a commit that referenced this pull request Sep 14, 2023
@freeekanayaka
uv/append: Don't call uvMaybeFireCloseCb in uvAliveSegmentWriterClose…
12b58f6 
…Cb (#45)

We actually don't track that there are pending segment writer close
operations, so this call to uvMaybeFireCloseCb() can't really unblock
anything waiting on it.

On the contrary, if it fires after the close callback has actually been
fired, it causes a double free:

==199067==ERROR: AddressSanitizer: attempting double-free on
0x602000000010 in thread T0:
#0 0x7fd5e44d7288 in __interceptor_free
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52
    #1 0x7fd5e4b5a259 in ioCloseCb src/raft.c:115
    #2 0x7fd5e4b84861 in uvMaybeFireCloseCbReal src/uv.c:202
#3 0x7fd5e4afba70 in uv_run (/lib/x86_64-linux-gnu/libuv.so.1+0xfa70)
(BuildId: 7f7f8c148150666c7b116bf98bf6e27f96c697a9)
    #4 0x55b25438ebe5 in SubmitRun tools/benchmark/submit.c:314
    #5 0x55b254388955 in main tools/benchmark/main.c:60
#6 0x7fd5e42456c9 (/lib/x86_64-linux-gnu/libc.so.6+0x276c9) (BuildId:
072feb34c63e054d60d94cbc68d92e4caad25d72)
#7 0x7fd5e4245784 in __libc_start_main
(/lib/x86_64-linux-gnu/libc.so.6+0x27784) (BuildId:
072feb34c63e054d60d94cbc68d92e4caad25d72)
#8 0x55b254388bf0 in _start
(/home/free/src/c/raft/tools/.libs/raft-benchmark+0x7bf0) (BuildId:
09105ce7d1a7fe71ca812de2af648a85fc490ebb)

0x602000000010 is located 0 bytes inside of 15-byte region
[0x602000000010,0x60200000001f) freed by thread T0 here:
#0 0x7fd5e44d7288 in __interceptor_free
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:52
    #1 0x7fd5e4b5a259 in ioCloseCb src/raft.c:115
    #2 0x7fd5e4b84861 in uvMaybeFireCloseCbReal src/uv.c:202
#3 0x7fd5e4afba70 in uv_run (/lib/x86_64-linux-gnu/libuv.so.1+0xfa70)
(BuildId: 7f7f8c148150666c7b116bf98bf6e27f96c697a9)

previously allocated by thread T0 here:
#0 0x7fd5e44d85bf in __interceptor_malloc
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7fd5e4b59983 in raft_init src/raft.c:62
    #2 0x55b25438e7d4 in serverInit tools/benchmark/submit.c:127
    #3 0x55b25438ebbf in SubmitRun tools/benchmark/submit.c:302
    #4 0x55b254388955 in main tools/benchmark/main.c:60
#5 0x7fd5e42456c9 (/lib/x86_64-linux-gnu/libc.so.6+0x276c9) (BuildId:
072feb34c63e054d60d94cbc68d92e4caad25d72)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@freeekanayaka