Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug]: 'Copy to clipboard' option doesn't work outside localhost #9

Closed
cp2004 opened this issue Jan 8, 2023 · 1 comment
Closed

[Bug]: 'Copy to clipboard' option doesn't work outside localhost #9

cp2004 opened this issue Jan 8, 2023 · 1 comment
Labels
confirmed bug Bug reproduced and needs to be fixed solved Solved, but not yet released.

Comments

@cp2004
Copy link
Owner

cp2004 commented Jan 8, 2023

Description of the bug

Browsers only support the navigator.clipboard API when pages are served over https, or on localhost (useful for testing I guess). Outside here, copy to clipboard did not work.

I guess we will have to fall back to the deprecated document.execCommand approach instead.

Plugin version

1.0.3

OctoPrint version

1.8.6

OctoPrint logs

Clipboard not supported
> navigator.clipboard
undefined
cp2004 added a commit that referenced this issue Jan 9, 2023
@cp2004
🐛 Fix code copy to clipboard
20ce403 
See #9
@cp2004 cp2004 added bug confirmed bug Bug reproduced and needs to be fixed solved Solved, but not yet released. and removed bug labels Jan 9, 2023
@cp2004
Copy link
Owner Author

cp2004 commented Jan 9, 2023

1.0.4 has been released, fixing a number of issues including this one.

@cp2004 cp2004 closed this as completed Jan 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
confirmed bug Bug reproduced and needs to be fixed solved Solved, but not yet released.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cp2004