Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch utils for non recursive links #7

Merged
merged 1 commit into from
May 22, 2015
Merged

Conversation

nhumrich
Copy link
Contributor

@nhumrich nhumrich commented May 5, 2015

Currently RecurisionError is thrown even for sideways links. This change checks for a recursive link versus a duplicate link and handles them differently.

Currently RecursionError is thrown even on sideways symlinks. This fix checks for recursive links versus sideways links.
@cpburnz
Copy link
Owner

cpburnz commented May 21, 2015

@nhumrich Can you provide an example of a "sideways" link? It's not really clear to me what one is.

@nhumrich
Copy link
Contributor Author

Ya sorry, I should be more correct in the words I use. Basically, just any link thats not recursive. But a simple example is:
./foo/bar -> ./foo/baz
Since bar points to baz and baz doesnt contain bar, there is no recursion and everything works ok.

cpburnz added a commit that referenced this pull request May 22, 2015
Patch utils for non recursive links
@cpburnz cpburnz merged commit 23eb432 into cpburnz:master May 22, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants