Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[module.global.frag] Simplify wording #6417

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[module.global.frag] Simplify wording #6417

merged 1 commit into from
Nov 10, 2023

Conversation

lprv
Copy link
Contributor

@lprv lprv commented Jul 25, 2023

@lprv
[module.global.frag] Simplify wording
612d790 
Also make variable order consistent across bullets.
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 10, 2023

@opensdh Would you have thoughts on whether this is a useful (and correct) simplification?

@opensdh
Copy link
Contributor

opensdh commented Nov 10, 2023

Seems right to me; I think the modules wording predates having a good definition of "declare the same entity", as silly as that sounds.

jensmaurer
jensmaurer approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 10, 2023

Thanks, everyone!

@tkoeppe tkoeppe merged commit d8b72f0 into cplusplus:main Nov 10, 2023
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lprv @tkoeppe @opensdh @jensmaurer