Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[version.syn] Bump value of __cpp_lib_constexpr_complex #6421

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

cpplearner
Copy link
Contributor

P1383R2 "More constexpr for <cmath> and <complex>" modifies two headers. 8571e94 updated __cpp_lib_constexpr_cmath, but I believe that __cpp_lib_constexpr_complex should also be updated.

SD6 already lists this new value. See https://wg21.link/sd6#__cpp_lib_constexpr_complex.

Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.
#6343 updated __cpp_lib_constexpr_cmath,
which the paper had also omitted.

@jensmaurer
Copy link
Member

@jwakely , what do you think?

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 14, 2023

@jwakely, @CaseyCarter: thoughts?

@cpplearner
Copy link
Contributor Author

ping @jwakely @CaseyCarter

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing the pings, I agree with this suggestion.

@tkoeppe tkoeppe merged commit a700e3b into cplusplus:main Nov 8, 2023
2 checks passed
@jensmaurer
Copy link
Member

@tkoeppe , should this go to the DIS as well?

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2023

Sure, will do!

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2023

Wait, no, the paper is for C++26.

@cpplearner cpplearner deleted the patch-2 branch November 8, 2023 03:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants