Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[exec] Index many library names. #7178

Closed
wants to merge 1 commit into from
Closed

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jul 28, 2024

No description provided.

@Eelis Eelis force-pushed the execindex branch 2 times, most recently from 117bbf3 to ec213eb Compare July 28, 2024 18:28
@Eelis
Copy link
Contributor Author

Eelis commented Jul 28, 2024

Oh, I just noticed this one conflicts with #7169 . Probably best to sort that one out first, and then I'll rebase this one.

@@ -2169,7 +2169,7 @@
\begin{itemdecl}
template<@\libconcept{sender}@ Sndr, @\exposconcept{queryable}@... Env>
requires (sizeof...(Env) <= 1)
constexpr @\libconcept{sender}@ decltype(auto) transform_sender(Sndr&& sndr, const Env&... env)
constexpr @\libconcept{sender}@ decltype(auto) @\libmember{transform_sender}{default_domain}@(Sndr&& sndr, const Env&... env)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For \itemdecls, we traditionally add \indexlibrarymember or \indexlibraryglobal before the \itemdecl, instead of adding inline indexing. In particular, since \libmember makes it even harder to see what the actual (visible) text will be.

I'd merge the changes to [execution.syn] right away, though, if you want to make a separate pull request for those.

@jensmaurer
Copy link
Member

I think this has been addressed by #7343. @Eelis , could you double-check?

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 6, 2024
@Eelis
Copy link
Contributor Author

Eelis commented Nov 9, 2024

Yep, resolved, thanks.

@Eelis Eelis closed this Nov 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants