[2025-02 LWG 14] P2846R6 reserve_hint: Eagerly reserving memory for not-quite-sized lazy ranges #7698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
reviewed
Feb 20, 2025
|
It would seem the changes adding index entries are unrelated and should be done in a separate (editorial) PR |
I believe indexes are editorial and discretionary. We add them as we see fit. That said, I did go a bit overboard here; I probably should have just fixed the references added in this paper, but since it's purely editorial (they don't change any wording), I'm hoping it's OK. |
cor3ntin
reviewed
Feb 25, 2025
tkoeppe
force-pushed
the
motions-2025-02-lwg-14
branch
from
0933cbb to
df23ae2
Compare
tkoeppe
force-pushed
the
motions-2025-02-lwg-14
branch
2 times, most recently
from
12ee273 to
bad0493
Compare
…zy ranges The wording has been reconciled with the earlier changes from the resolution of issue LWG 4189, which made most of <ranges> free-standing, noting "Most future additions to this header should have no problem being freestanding, so that is the right default." Consequently, "reserve_hint" and "approximately_sized_range" are now also free-standing.
tkoeppe
force-pushed
the
motions-2025-02-lwg-14
branch
from
bad0493 to
71a9d38
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7673.
Fixes cplusplus/papers#1549.