[text.encoding.id] Sort enumerators in ascending order #7899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some enumerators of `std::text_encoding::id` are listed out of order. It's probably better to sort them in ascending order.
|
Seems like a simple editorial mistake; I couldn't find a pattern in the text encodings that would explain IBM423 = 2042,
IBM424 = 2043,
PC8CodePage437 = 2011,
IBM500 = 2044,
IBM851 = 2045,@cor3ntin can you confirm this was just a slip-up? |
|
The PR is consistent with the RFC, so this seems fine https://www.rfc-editor.org/rfc/rfc3808.html |
jensmaurer
approved these changes
May 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some enumerators of
std::text_encoding::idare listed out of order. It's probably better to sort them in ascending order.