Added basic WASD movement. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quad is static on program start. W-UP A-LEFT S-DOWN D-RIGHT
…d_map. Removed unused include, removed unused variables. Currently working on adding flags to allow diagonal movement. And stoping movement on key_release.
…ment is included.
swagween
previously requested changes
Feb 12, 2024
karnkaul
requested changes
Feb 16, 2024
karnkaul
approved these changes
Feb 16, 2024
swagween
reviewed
Feb 16, 2024
| if (direction.x != 0.0f || direction.y != 0.0f) { | ||
| direction = glm::normalize(direction); | ||
| auto const displacement = direction * speed_v * dt.count(); | ||
| m_physics.position += displacement; |
There was a problem hiding this comment.
shouldn't movement adjust the player's acceleration rather than editing the position directly? and if you don't want movement to have the same "feel" as gravity, you just need custom x-direction multipliers.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quad is static on program start.
W-UP
A-LEFT
S-DOWN
D-RIGHT
Basic wall collision using Jake's prior collision.