-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enable parallelism #213
Enable parallelism #213
Conversation
FYI, dependabot will submit a PR that will update the CLI pkg when we release the changes in cpp-linter/cpp-linter#92. Until then we have other testing that we're trying to get done, so this will be in idle for the meantime. |
Yeah, we can do a patch release right now. I have no objection to that. As for parallelism, it should definitely be a minor version bump. I just did the same bump for cpp-linter. Once dependabot submits the PR for cpp-linter v1.8.0, I'll be rebasing this branch and supplementing it with doc info. |
See cpp-linter/cpp-linter#92 for the related CLI updates.
Ok, I force-pushed a docs-related commit after rebasing the branch. I think the self-test CI failed again because the PR is coming from a public fork, thus the token permission is inadequate to post a thread comment. This is what the
This message is not entirely informative, but that's all we get from github REST API 403 response. |
Introduce |
Agreed. I don't see a good workaround right now. I added the |
|
It is designed to let a "known good" CI workflow (the target branch's config) run changes in the PR. But, it ignores any incoming changes in the CI workflows config. There is no way to allow comments to be posted using PR changes in a CI workflow from a public fork. That is the exact security risk that |
See cpp-linter/cpp-linter#92 for the related CLI updates.