Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI: Better Benchmark #92

Merged
merged 4 commits into from
Jan 4, 2025
Merged

CI: Better Benchmark #92

merged 4 commits into from
Jan 4, 2025

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Jan 2, 2025

Uses codspeed action and binary to gather performance info and produce results. More details at docs.codspeed.io.

I also went through and made some minor adjustments to the algorithms, so that they behave more like the pure python source.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 98.99497% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.84%. Comparing base (0687d8e) to head (8327dae).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cpp-linter/src/logger.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   97.83%   97.84%           
=======================================
  Files          14       14           
  Lines        3425     3474   +49     
=======================================
+ Hits         3351     3399   +48     
- Misses         74       75    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 1 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • scan libgit2 (10.3 s)

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Jan 2, 2025

Took over 33 minutes to run the benchmark though.

@2bndy5 2bndy5 force-pushed the benchmark branch 4 times, most recently from b2d737e to 47e80a1 Compare January 3, 2025 00:23
2bndy5 added 3 commits January 2, 2025 19:52
only run benchmark on changes that effect performance
ignore logger init errors
move helper function to gh-specific API
@2bndy5 2bndy5 marked this pull request as ready for review January 4, 2025 00:37
@2bndy5 2bndy5 merged commit b883ba6 into main Jan 4, 2025
55 checks passed
@2bndy5 2bndy5 deleted the benchmark branch January 4, 2025 04:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant