Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#481 - Pass metric name via constructor. #485

Closed
wants to merge 1 commit into from

Conversation

vzurauskas
Copy link
Contributor

PR for #481

Passing metric name via constructor to fit the Calculus interface to Java implementations.

@vzurauskas
Copy link
Contributor Author

@paulodamaso Can you check why no reviewer has been assigned?

@paulodamaso
Copy link
Collaborator

@0crat in

@0crat
Copy link
Collaborator

0crat commented Sep 19, 2020

@0crat in (here)

@paulodamaso Job #485 is already in scope

@paulodamaso
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Sep 19, 2020

@0crat status (here)

@paulodamaso This is what I know about this job in C7JGJ00DP, as in §32:

  • The job #485 is in scope for 2mon
  • The role is REV
  • The job is not assigned to anyone
  • The budget is not set yet
  • These users are banned and won't be assigned:
  • Job footprint (restricted area)

@paulodamaso
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 31, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@0crat
Copy link
Collaborator

0crat commented Oct 31, 2020

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@9ca55d38-31cb-44eb-9fbd-eb71fd9e124a, thread: pool-134-thread-1
com.zerocracy.radars.github.GhProject[69] com.zerocracy.radars.github.GhProjectNotFoundException: Github project for 'cqfn/jpeek' repo was not found

0.54.5: Issue: #485, Comment: 695219680

@0crat
Copy link
Collaborator

0crat commented Oct 31, 2020

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@9ca55d38-31cb-44eb-9fbd-eb71fd9e124a, thread: pool-135-thread-1
com.zerocracy.radars.github.GhProject[69] com.zerocracy.radars.github.GhProjectNotFoundException: Github project for 'cqfn/jpeek' repo was not found

0.54.5: Issue: #485, Comment: 695220632

@rultor
Copy link
Collaborator

rultor commented Oct 31, 2020

@rultor merge

@paulodamaso @vzurauskas Oops, I failed. You can see the full log here (spent 16s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 31725
+ echo '1.69.1 839260fab'
1.69.1 839260fab
+ date
Sat Oct 31 16:31:22 CET 2020
+ uptime
 16:31:22 up 34 days,  1:37,  0 users,  load average: 1.09, 0.67, 0.34
+ cat
.rultor.yml in yegor256/home doesn't allow cqfn/jpeek to use its assets (there are 108 friends), see http://doc.rultor.com/reference.html#assets
+ exit -1
'cid' file is absent, container wasn't started correctly

@paulodamaso
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 11, 2021

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jan 11, 2021

@rultor merge

@paulodamaso @vzurauskas Oops, I failed. You can see the full log here (spent 16s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 406
+ echo '1.69.1 839260fab'
1.69.1 839260fab
+ date
Mon Jan 11 21:43:12 CET 2021
+ uptime
 21:43:12 up 106 days,  6:49,  0 users,  load average: 0.16, 0.33, 0.23
+ cat
.rultor.yml in yegor256/home doesn't allow cqfn/jpeek to use its assets (there are 108 friends), see http://doc.rultor.com/reference.html#assets
+ exit -1
'cid' file is absent, container wasn't started correctly

@paulodamaso
Copy link
Collaborator

@yegor256 could you please fix this? Seems that renaming the repo messed with some asset permissions in yegor256/home

@@ -171,123 +170,122 @@ public void analyze() throws IOException {
final XSL chain = new XSLChain(layers);
this.save(skeleton.toString(), "skeleton.xml");
final Collection<Report> reports = new LinkedList<>();
final Calculus xsl = new XslCalculus();
if (this.params.containsKey("LCOM")) {
Copy link
Member

@baudoliver7 baudoliver7 Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vzurauskas Why not use an iteration on snippet :

if (this.params.containsKey(code)) {
    reports.add(
        new XslReport(
            chain.transform(skeleton), new XslCalculus(code),
             new ReportData(code, this.params, mean, sigma)
        )
    );
}

with code, mean and sigma some parameters. You could use mean and sigma default values where it appears only two parameters in ReportData constructor. You can also create a todo for that if you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baudoliver7 That is a good suggestion, however this PR has been blocked for a very long time and I no longer have the time to work on it (at least in the near future). You can take it over if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vzurauskas Ok. But how can I do that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baudoliver7 You can ask @paulodamaso to assign this task to you and then copy this branch.

yegor256 added a commit that referenced this pull request Feb 5, 2021
@yegor256
Copy link
Member

yegor256 commented Feb 5, 2021

@paulodamaso done in 18efdff

@baudoliver7
Copy link
Member

@paulodamaso could you assign to me this PR ? I want to do some few changes on it.

@baudoliver7
Copy link
Member

@paulodamaso ping

@vzurauskas vzurauskas closed this Mar 31, 2023
@0crat
Copy link
Collaborator

0crat commented Mar 31, 2023

Job gh:cqfn/jpeek#485 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Apr 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants