Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

APHL-1013-revert_3part_version #480

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

ibaisi
Copy link
Contributor

@ibaisi ibaisi commented Jun 11, 2024

remove revision from release version to leave 3 part version

Copy link

github-actions bot commented Jun 11, 2024

Formatting check succeeded!

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.00%. Comparing base (862b4b1) to head (e5ed8eb).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #480   +/-   ##
=========================================
  Coverage     62.00%   62.00%           
  Complexity     3552     3552           
=========================================
  Files           328      328           
  Lines         17574    17574           
  Branches       2707     2707           
=========================================
  Hits          10897    10897           
  Misses         5472     5472           
  Partials       1205     1205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few style changes.
Looks good to me, tests pass.

@sliver007 sliver007 merged commit d45dc73 into master Jun 12, 2024
7 checks passed
@sliver007 sliver007 deleted the APHL-1013-revert_3part_version branch June 12, 2024 03:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants