Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new EvaluationSettings for client timezone. Default to UTC if this is not set. #529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Sep 24, 2024

  • Add new EvaluationSettings for client timezone. Default to UTC if this is not set.
  • Ensure all Interval and Period calculation uses this timezone.
  • Ensure InMemoryFhirRepository doesn't throw when calling transaction()

Closes #528

…s is not set. Ensure all Interval and Period calculation uses this timezone.
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.10%. Comparing base (f0439b3) to head (f14ce7e).

Files with missing lines Patch % Lines
...a/org/opencds/cqf/fhir/cql/EvaluationSettings.java 40.00% 3 Missing ⚠️
.../cqf/fhir/cr/measure/MeasureEvaluationOptions.java 33.33% 2 Missing ⚠️
...cds/cqf/fhir/cr/measure/helper/IntervalHelper.java 75.00% 1 Missing ⚠️
...hir/utility/repository/InMemoryFhirRepository.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #529      +/-   ##
============================================
- Coverage     67.10%   67.10%   -0.01%     
- Complexity     4103     4106       +3     
============================================
  Files           353      354       +1     
  Lines         18063    18067       +4     
  Branches       2792     2793       +1     
============================================
+ Hits          12121    12123       +2     
- Misses         4735     4739       +4     
+ Partials       1207     1205       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy marked this pull request as ready for review September 24, 2024 14:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure measurement periods respect configured timezone or UTC default
1 participant