Loosen IMU acceleration IO test #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Audrow Nash <audrow@hey.com>
|
I'm a little concerned that these tests seem to do this more often in ROS 2 than in ROS 1. That doesn't prevent me from wanting to merge this. Just stating. I plan to resume a more active role in maintenance of this package soon, so I'll be looking into that. In the meantime, thanks for the PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing occasionally for me (Ubuntu 20.04 with Rolling), but not by much. In one place, the test is expecting a value less than 0.4, but is getting values, in my experience, that may be a little greater than 0.5. This PR increases the value to 0.6 so that the test doesn't fail as frequently.