Fixed #2720

craftcms · Apr 11, 2018 · 4266f83 · 4266f83
1 parent 53695af
commit 4266f83
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/CHANGELOG-v3.md b/CHANGELOG-v3.md
@@ -1,5 +1,10 @@
 # Release Notes for Craft CMS 3.x
 
+## Unreleased
+
+### Fixed
+- Fixed a bug where the Clear Caches utility was not deleting template caches. ([#2720](https://github.com/craftcms/cms/issues/2720))
+
 ## 3.0.2 - 2018-04-10
 
 ### Added

diff --git a/src/services/TemplateCaches.php b/src/services/TemplateCaches.php
@@ -428,15 +428,15 @@ public function deleteCachesByElementType(string $elementType): bool
             return false;
         }
 
-        $this->_deletedCachesByElementType[$elementType] = true;
-
         $cacheIds = (new Query())
             ->select(['cacheId'])
             ->from([self::$_templateCacheQueriesTable])
             ->where(['type' => $elementType])
             ->column();
 
-        return $this->deleteCacheById($cacheIds);
+        $success = $this->deleteCacheById($cacheIds);
+        $this->_deletedCachesByElementType[$elementType] = true;
+        return $success;
     }
 
     /**
@@ -586,15 +586,15 @@ public function deleteExpiredCaches(): bool
             return false;
         }
 
-        $this->_deletedExpiredCaches = true;
-
         $cacheIds = (new Query())
             ->select(['id'])
             ->from([self::$_templateCachesTable])
             ->where(['<=', 'expiryDate', Db::prepareDateForDb(new \DateTime())])
             ->column();
 
-        return $this->deleteCacheById($cacheIds);
+        $success = $this->deleteCacheById($cacheIds);
+        $this->_deletedExpiredCaches = true;
+        return $success;
     }
 
     /**
@@ -634,14 +634,14 @@ public function deleteAllCaches(): bool
             return false;
         }
 
-        $this->_deletedAllCaches = true;
-
         $cacheIds = (new Query())
             ->select(['id'])
             ->from([self::$_templateCachesTable])
             ->column();
 
-        return $this->deleteCacheById($cacheIds);
+        $success = $this->deleteCacheById($cacheIds);
+        $this->_deletedAllCaches = true;
+        return $success;
     }
 
     // Private Methods