Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Propagate versions for channel/structure entries #2669

Closed
colinmeinke opened this issue Apr 3, 2018 · 7 comments
Closed

Propagate versions for channel/structure entries #2669

colinmeinke opened this issue Apr 3, 2018 · 7 comments
Labels
content modeling 📓 features related to content modeling enhancement improvements to existing features

Comments

@colinmeinke
Copy link

Description

When I create a new channel with entry versioning and select “propagate across all enabled sites”, on editing an entry content is propagated, but versions are only added for the current site.

I would expect versions to be added for all sites. If not, how do you got about creating "global" content with versions?

Steps to reproduce

  1. Setup a Craft install with multiple sites.
  2. Create a channel, with versioning and “propagate across all enabled sites” enabled.
  3. Create an entry.
  4. Edit that entry.
  5. View the entry versions table, version have only been added for the current site.

Additional info

  • Craft version: 3.0.0-RC17.1
@carlcs
Copy link
Contributor

carlcs commented Apr 4, 2018

An enabled “propagate across all enabled sites” setting only makes sure that all of the section’s entries always exist for all sites. Content can still be unique per site (depends on the fields’ translation settings), so entry versions have to be stored per site as well.

What I’d suggest for global content is to create the section for one site only and then use the site parameter in your element queries.

@colinmeinke
Copy link
Author

Thanks, this is what I ended up doing. It just doesn't feel right from a UX perspective, but I can see the technical reasons for it.

@carlcs
Copy link
Contributor

carlcs commented Apr 4, 2018

@colinmeinke you might want to leave this open and see what P&T has to say

@colinmeinke colinmeinke reopened this Apr 4, 2018
@brandonkelly
Copy link
Member

Yeah considering content is per-site, so should entry drafts/versions.

@colinmeinke
Copy link
Author

@brandonkelly I think this may need revisiting. This doesn't seem right conceptually:

  1. Create a new structure, enable versioning, enabled on 4 sites.
  2. Create an entry for the new structure, content is updated for all sites, but a version is only added for the site I am editing.
  3. Edit the entry 2 more times, content is updated for all sites, but again a version is only added for the site I am editing.

In reality, all sites have had 3 versions, but only the site that I was editing has been added to the entryversions table. I understand this is really tricky technically as some fields can be translatable, but I feel that if the state of an entry changes at all for a specific site, then a new version should be added.

@brandonkelly
Copy link
Member

@colinmeinke Yeah I guess I could see that. I’lr reopen, and will consider this when we rewrite the revision system (planned for a future 3.x release).

@brandonkelly brandonkelly reopened this May 9, 2018
@brandonkelly brandonkelly added enhancement improvements to existing features content modeling 📓 features related to content modeling labels May 9, 2018
brandonkelly added a commit that referenced this issue May 17, 2019
Resolves #1021
Resolves #1034
Resolves #1135
Resolves #1231
Resolves #1489
Resolves #1787
Resolves #2120
Resolves #2325
Resolves #2669
Resolves #2909
Resolves #3349
Resolves #3392
Resolves #926
@brandonkelly
Copy link
Member

This has been added for the next 3.2 Alpha release!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
content modeling 📓 features related to content modeling enhancement improvements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants