-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add rel="noopener"
for all external links
#3201
Comments
Craft already sets a referrer policy for all Control Panel pages, so this is not necessary. cms/src/templates/_layouts/base.html Line 19 in 2058b4c
|
@brandonkelly: this is not related to the referrer. Please read the links above. |
Sorry, misread. |
Do you want me to push my current PR? Some changes might not be right, but I can rebase after any feedback. |
Sure. |
Done in #3202. |
brandonkelly
added a commit
that referenced
this issue
Aug 15, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
References
There are some links dynamically created in JS; those should have it too.
I have a local branch which takes care of this, but since I'm not familiar with the code base I decided not to submit it. If it'll help, I can make a PR, though.
The text was updated successfully, but these errors were encountered: