Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my PR incorporating some changes mentioned in #2992. A detailed outline of my changes are at the bottom of this comment.
Most all of the group-related functions in the
Tags
service havetagGroup
in their name, opposed to the other services that have 'group', and I figured asking if deprecating all of those would be a good idea in order to rename them, or if leaving it alone would be better for anyone maintaining things. If a change is preferred, I wouldn't mind making that change and adding it to this PR, or a future one if need be. For now, my change to theTags
service has followed its own naming convention instead of the other services.Also, in the initial issue, I pointed out the
Structures
service and its lack of adeleteStructure()
function. Though it's worth mentioning that after looking through the source, I now understand why that service is built the way it is, and how my previous assumption doesn't apply in this instance.Changes within this pull request were broken into three commits:
/craft/controllers/TagsController
actionDeleteTagGroup()
to better namesectionId
togroupId
./craft/services/Categories
deleteGroup()
, which now contains the bulk of the logic thatdeleteGroupById()
had.deleteGroupById()
to forward todeleteGroup()
after retrieving and verifying the group./craft/services/Tags
deleteTagGroup()
, which now contains the bulk of the logic thatdeleteTagGroupById()
had.deleteTagGroupById()
to forward todeleteTagGroup()
after retrieving and verifying the group./craft/services/UserGroups
deleteGroup()
, which now contains the bulk of the logic thatdeleteGroupById()
had.deleteGroupById()
to forward todeleteGroup()
after retrieving and verifying the group./craft/services/AssetTransforms
deleteTransformById()
which will accept an ID, and forward todeleteTransform()
after retrieving and verifying the transform.deleteTransform()
to accept anAssetTransform
object.deleteTransform()
to raise deprecation warnings when called with an integer ID./craft/controllers/AssetTransformsController
actionDeleteTransform()
to call the updateddeleteTransformById()
function of theAssetTransforms
service.