Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: split attestation bits from metsys plugin #438

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: split attestation bits from metsys plugin #438

merged 2 commits into from
Nov 5, 2024

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Nov 4, 2024

Issue

push report for non-chalked image had some keys missing such as _CHALK_RUN_TIME

Description

currently metsys plugin was reporting global metadata keys such as chalk run time as well as generating attestation bits such as artifact signature.

this meant that disabling metsys plugin to avoid assigning metadata id, etc would also not report global keys such as chalk run time

this was happening for docker push when pushing non-chalked image

Testing

➜ make tests args="test_docker.py::test_push_nonchalked --logs"

currently metsys plugin was reporting global metadata keys such as chalk
run time as well as generating attestation bits such as artifact
signature.

this meant that disabling metsys plugin to avoid assigning metadata id,
etc would also not report global keys such as chalk run time

this was happening for docker push when pushing non-chalked image
@miki725 miki725 marked this pull request as ready for review November 5, 2024 14:20
@miki725 miki725 requested a review from viega as a code owner November 5, 2024 14:20
@miki725 miki725 merged commit eab26f0 into main Nov 5, 2024
4 checks passed
@miki725 miki725 deleted the sc-2927 branch November 5, 2024 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants