Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: semgrep needs to be on PATH #439

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: semgrep needs to be on PATH #439

merged 1 commit into from
Nov 5, 2024

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Nov 5, 2024 •
edited
Loading

Issue

when docker is not available, installed semgrep via chalk cannot run

Description

starting with 1.94.0, if semgrep is not on PATH, its not able to run and throws:

Error: exception Unix_error: No such file or directory execvp pysemgrep

related issue semgrep/semgrep#10652

Testing

➜ make tests args="test_plugins.py::test_semgrep[sample_1-False] --logs --pdb"

@miki725
fix: semgrep needs to be on PATH
f025232 
starting with 1.94.0, if semgrep is not on PATH, its not able to run and
throws:

```
Error: exception Unix_error: No such file or directory execvp pysemgrep
```
@miki725 miki725 marked this pull request as ready for review November 5, 2024 13:49
@miki725 miki725 requested a review from viega as a code owner November 5, 2024 13:49
@miki725 miki725 merged commit a470a59 into main Nov 5, 2024
4 checks passed
@miki725 miki725 deleted the sc-3113 branch November 5, 2024 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@indecisivedragon indecisivedragon indecisivedragon approved these changes

@viega viega Awaiting requested review from viega viega is a code owner

@mbaltrusitis mbaltrusitis Awaiting requested review from mbaltrusitis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miki725 @indecisivedragon