Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Fold/collapse icons overlapping the text #40

Closed
JeFawk opened this issue Jan 22, 2024 · 5 comments
Closed

[BUG] Fold/collapse icons overlapping the text #40

JeFawk opened this issue Jan 22, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@JeFawk
Copy link

JeFawk commented Jan 22, 2024

Describe the bug

First I would like to thank you for this free theme, it's great!

image

To Reproduce

Steps to reproduce the behavior:

  1. Type something
  2. Press enter and tab to create an indented text
  3. Notice the top text has a collapse icon
  4. Notice the overlap

Information

  • OS: Windows

Add other context about the problem here. (Please make sure you've updated the theme before opening an issue.)

Suggestions/Workarounds

Add any suggestions/workarounds on how to resolve the issue here.

@JeFawk JeFawk added the bug Something isn't working label Jan 22, 2024
@JeFawk
Copy link
Author

JeFawk commented Jan 22, 2024

If you select the text block that has the fold (select as in put the cursor on it) for some reason it shows correctly

image

@JeFawk
Copy link
Author

JeFawk commented Jan 22, 2024

Also the cursor is offset.
image

image

This offset is just graphical as there is no space there, if i type something it puts a letter right next to the C, even though it would look like it would be letter _ C (_ from empty space)

JeFawk added a commit to JeFawk/obsidian-typewriter that referenced this issue Jan 22, 2024
@JeFawk
Copy link
Author

JeFawk commented Jan 22, 2024

This will fix it

div.cm-fold-indicator
{
  margin-right: 0;
}
.markdown-source-view.mod-cm6 .cm-fold-indicator .collapse-indicator
{
  padding-right: 4px;
  right: 0;
}

JeFawk added a commit to JeFawk/obsidian-typewriter that referenced this issue Jan 22, 2024
Previous fix added margin to the title of the folded block, this fix removes that.
@crashmoney
Copy link
Owner

Hey, thanks for the issue and fix provided! This looks like a bug that's cropped up in newer versions of Obsidian.

I'll merge this into main once I get some spare time.

@crashmoney
Copy link
Owner

Strangely enough, I can't reproduce this issue on my machine. I've tried both indented normal text and bullets. It doesn't change the look at all, so I'll go on ahead and push this through main for anyone else experiencing the same bug 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants