Fix background color for titlebar buttons on Windows #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crashmoney
requested changes
May 1, 2024
|
Hey @orellazri, thanks so much for the fix! I must have missed the alert for this 😅 Very appreciated, considering that I don't use Windows myself. I've left my comments on a review! |
orellazri
force-pushed
the
fix-titlebar-windows
branch
from
e7ae408 to
a693aed
Compare
|
@crashmoney No worries! Thanks for looking into my PR. I moved my change into |
|
Looks great! Merging this in :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the background color for titlebar buttons on Windows and addresses #37
It seems that this bug only affects the theme when running in dark mode.
Before:
After (Dark):
After (Light):
