New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ignore binary files #29

Closed

epage opened this issue Jul 13, 2019 · 3 comments · Fixed by #36

Labels

Milestone

Collaborator

epage commented Jul 13, 2019

Copy the flags from ripgrep: https://github.com/BurntSushi/ripgrep/blob/master/src/app.rs#L745

Exposed as https://github.com/BurntSushi/ripgrep/blob/master/src/args.rs#L902

epage added the enhancement label

epage added this to the 0.1 milestone

Collaborator Author

epage commented Jul 14, 2019

Codespell ignores files with a null character in the first 1024 bytes
https://github.com/codespell-project/codespell/blob/master/codespell_lib/_codespell.py#L351

scspell-go first checks some know extensions
https://github.com/client9/misspell/blob/master/mime.go#L61
Otherwise, it checks for know magic numbers and falls back to mime detction
https://github.com/client9/misspell/blob/master/mime.go#L124

Both cases are unconditional.

Collaborator Author

epage commented Jul 14, 2019

Looks like ripgrep uses null byte detection

Collaborator Author

epage commented Jul 14, 2019

Probably going to implement this in a fast turn around way and then open an issue to speed it up.

epage mentioned this issue

Speed up detection of binary files #34

Closed

epage added a commit that referenced this issue


          feat: Ignore binary files

da156e3

Fixes #29

epage mentioned this issue

feat: Ignore binary files #36

Merged

epage closed this as completed in #36

# for free to join this conversation on GitHub. Already have an account? # to comment