Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change reported docker client version to 1.24 #310

Closed
wants to merge 1 commit into from
Closed

Change reported docker client version to 1.24 #310

wants to merge 1 commit into from

Conversation

lafriks
Copy link

@lafriks lafriks commented Jan 22, 2024

Fixes #307

@lafriks
Change reported docker client version to 1.24
33b409c 
Fixes usage with latest docker versions
@lafriks lafriks requested a review from crazy-max as a code owner January 22, 2024 09:26
@kumy
Copy link

kumy commented Jan 22, 2024

Also tested this fix, 👍 from my side

@Yanik39
Copy link

Yanik39 commented Jan 24, 2024 

Server: Docker Engine - Community
 Engine:
  Version:          25.0.0
  API version:      1.44 (minimum version 1.24)
  ...

Why we are following minimum version?

@jorrit
Copy link

jorrit commented Jan 31, 2024

@Yanik39 Is right, maybe increase the version even further, otherwise the same problem is going to appear next year.

@crazy-max
Copy link
Owner

Maybe using API version negotiation would be better, I will take a look.

@crazy-max crazy-max mentioned this pull request Jan 31, 2024
Merged
@lafriks lafriks closed this Jan 31, 2024
@lafriks lafriks deleted the fix/docker_cli_version branch January 31, 2024 11:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@crazy-max crazy-max Awaiting requested review from crazy-max crazy-max is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After Updating docker container no longer starts. it starts and immadiatley fails.
5 participants
@lafriks @kumy @Yanik39 @jorrit @crazy-max