Fix windows nghttp2 dynamic linking bug (#422)

* fix windows nghttp2 dynamic linking bug * add tests for fixing windows nghttp2 dynamic linking bug
crazywhalecc · Apr 25, 2024 · 1a87ce4 · 1a87ce4
1 parent 6b96feb
commit 1a87ce4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/SPC/builder/windows/library/nghttp2.php b/src/SPC/builder/windows/library/nghttp2.php
@@ -25,6 +25,8 @@ protected function build(): void
                 '-DCMAKE_BUILD_TYPE=Release ' .
                 '-DENABLE_SHARED_LIB=OFF ' .
                 '-DENABLE_STATIC_LIB=ON ' .
+                '-DBUILD_STATIC_LIBS=ON ' .
+                '-DBUILD_SHARED_LIBS=OFF ' .
                 '-DENABLE_STATIC_CRT=ON ' .
                 '-DENABLE_LIB_ONLY=ON ' .
                 '-DCMAKE_INSTALL_PREFIX=' . BUILD_ROOT_PATH . ' '

diff --git a/src/globals/test-extensions.php b/src/globals/test-extensions.php
@@ -14,7 +14,7 @@
 // If you want to test your added extensions and libs, add below (comma separated, example `bcmath,openssl`).
 $extensions = match (PHP_OS_FAMILY) {
     'Linux', 'Darwin' => 'intl,posix',
-    'Windows' => 'mbstring,pdo_sqlite,mbregex',
+    'Windows' => 'mbstring,pdo_sqlite,mbregex,curl',
 };
 
 // If you want to test lib-suggests feature with extension, add them below (comma separated, example `libwebp,libavif`).