Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make context menu xhtml compatible #18

Merged
merged 3 commits into from
Sep 23, 2016

Conversation

andreasplesch
Copy link
Contributor

addresses #13 for context menu

Since cobweb does not rebuild jquery-contextMenu from source and uses directly the dist/ file, this PR only affects dist/jquery.contextMenu.js .

swisnl/jQuery-contextMenu#451 is the upstream PR which may be slow to be merged.

@andreasplesch
Copy link
Contributor Author

https://andreasplesch.github.io/cobweb_dom/tests/x3d_script.xhtml
uses a patched cobweb.js with the PR merged. The context menu works.

@create3000 create3000 merged commit 7b27ecf into create3000:master Sep 23, 2016
create3000 added a commit that referenced this pull request Sep 23, 2016
@andreasplesch
Copy link
Contributor Author

https://andreasplesch.github.io/cobweb_dom/tests/x3d_script.xhtml uses now the latest cobweb.uncompressed.js and it works fine. Thanks.

@andreasplesch
Copy link
Contributor Author

swisnl/jQuery-contextMenu#451 is now merged upstream. So updating at some point to the latest jQuery-contextMenu in cobweb.js/lib/jquery-contextMenu/dist/ should be ok now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants